Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JavaScript Tracker: new option "Track users with JavaScript disabled" and the <noscript> tag is not included by default anymore #10900

Merged
merged 14 commits into from Dec 1, 2016
Merged

JavaScript Tracker: new option "Track users with JavaScript disabled" and the <noscript> tag is not included by default anymore #10900

merged 14 commits into from Dec 1, 2016

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Nov 23, 2016 •
edited

fix #10797

Removing noscript by default does not break API as it was not working before anyway because we did not set &rec=1. If we enabled noScript by default we would break API as we would suddenly record that data.

@tsteur tsteur added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Pull Request WIP Indicates the current pull request is still work in progress and not ready yet for a review. labels Nov 23, 2016
@tsteur tsteur added this to the 3.0.0-b4 milestone Nov 23, 2016
@tsteur
Copy link
Member Author

tsteur commented Nov 23, 2016

Ideally we squash this PR as there were many commits because of travis.yml

@tsteur tsteur added Needs Review PRs that need a code review and removed Needs Review PRs that need a code review Pull Request WIP Indicates the current pull request is still work in progress and not ready yet for a review. labels Nov 23, 2016
@mattab mattab changed the title Change default recommended JavaScript Tracking Code JavaScript Tracker: new option "Track users with JavaScript disabled" and the <noscript> tag is not included by default anymore Dec 1, 2016
@mattab mattab merged commit d61acca into 3.x-dev Dec 1, 2016
@mattab mattab deleted the 10797 branch December 1, 2016 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
3.0.0-b4
Development

Successfully merging this pull request may close these issues.

Change default recommended JavaScript Tracking Code
2 participants
@tsteur @mattab