Included $resolution for generating the Config Hash of the Visitor #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not sure if it's that good to add it to the hash. Resolution might change within one visit, maybe just by moving the browser window to another screen (with different resolution) |
|
I think it was there at one point and then removed... does resolution change when orientation changes? |
|
resolution changes within a visit, so we cant use it to seed the hash... |
|
In that case we should at least remove the parameter from the function. |
|
good point, done in a0d277e |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The $resolution on the function getConfigHash seem to have been ignored for generating the visitors configuation settings hash. Added that to the md5 function.