@abishekrsrikaanth opened this Pull Request on September 23rd 2013

The $resolution on the function getConfigHash seem to have been ignored for generating the visitors configuation settings hash. Added that to the md5 function.

@sgiehl commented on September 23rd 2013 Member

I'm not sure if it's that good to add it to the hash. Resolution might change within one visit, maybe just by moving the browser window to another screen (with different resolution)

@robocoder commented on September 23rd 2013 Contributor

I think it was there at one point and then removed... does resolution change when orientation changes?

@mattab commented on September 23rd 2013 Member

resolution changes within a visit, so we cant use it to seed the hash...

@halfdan commented on September 23rd 2013 Member

In that case we should at least remove the parameter from the function.

@mattab commented on September 25th 2013 Member
This Pull Request was closed on September 23rd 2013
Powered by GitHub Issue Mirror