Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Button to add a segment is missing some text in French language #10897

Merged
merged 2 commits into from Dec 1, 2016
Merged

Button to add a segment is missing some text in French language #10897

merged 2 commits into from Dec 1, 2016

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Nov 23, 2016

fixes #10656

It will look like this:

image

It is not ideal but I cannot lower the line-height because otherwise the button would not look nice when english language is used (or in general when button shows text in one line).

Maybe the button text could be on top changed to only say like "new segment"?

@tsteur tsteur added Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. labels Nov 23, 2016
@tsteur tsteur added this to the 3.0.0-b4 milestone Nov 23, 2016
@mattab mattab merged commit c9244e6 into 3.x-dev Dec 1, 2016
@mattab mattab deleted the 10656 branch December 1, 2016 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
3.0.0-b4
Development

Successfully merging this pull request may close these issues.

Button to add a segment is missing some text in French language
2 participants
@tsteur @mattab