@Slowlearneruk opened this Pull Request on November 22nd 2016

Please issue pull request against the 3.x-dev branch only.

Piwik 2 is in LTS mode. This means we do not accept any pull request for 2.x except critical security bugs and major data loss bugs.

If you need to create a pull request for 2.x, then please also create the pull request against the 3.x-dev so we can merge both.

Happy hacking!

@Slowlearneruk commented on November 22nd 2016

Hmm.. not very familiar with the submission procedure on Github.

In summary we are recording multiple purchase items with the same sku but different values on our site (these represent bets with different stakes on the same event). Consequently we need to permit an ecommerce request with multiple entries. As you can see, using an object with the sku as a key does not really work with this model but as it happens we can easily switch ecommerceItems to an array as the sku is also held in the item member.

@Slowlearneruk commented on November 22nd 2016

Done, what are your guidelines for browser support? Array.prototype.foreach seems to be covered by everything: http://kangax.github.io/compat-table/es5/#test-Array.prototype.forEach what am I missing?

Cheers, for feedback.

@tsteur commented on November 22nd 2016 Member

We also support IE 8, IE7, IE6 ,...

@mattab commented on November 22nd 2016 Member

I also gave this a try few months ago in https://github.com/piwik/piwik/pull/10297/files but then realised it is not that simple because At the moment in Piwik the Tracking API backend does expect at most one product with a given SKU, as there is a PRIMARY KEY(idvisit, idorder, idaction_sku), on log_ecommerce_item table...

@mattab commented on January 21st 2017 Member

If someone ever wants to work on this please re-create the PR and we can help with reviews etc. For us it's not a priority at this time

This Pull Request was closed on January 21st 2017
Powered by GitHub Issue Mirror