Tracking API: when overriding the request datetime with an invalid token_auth, don't track the request #10890
Milestone
Comments
|
Ideally we also need to make it configurable re how far in the back it is possible to track without needing token. Maybe we could also change default value from 4 hours to 24 hours? |
|
+1 (configurable + default to 24 hours) |
tsteur
added a commit
that referenced
this issue
Nov 23, 2016
…mestamps up to 1 day in past, added config for timestamps that require auth
mattab
pushed a commit
that referenced
this issue
Dec 1, 2016
…ken_auth, don't track the request (#10899) * refs #10890 ignore tracking requests with custom timestamp, accept timestamps up to 1 day in past, added config for timestamps that require auth * fix test * update travis yml * update travis * update travis * fix test * added changelog entry * .travis.yml file is out of date, auto-updating .travis.yml file. * .travis.yml file is out of date, auto-updating .travis.yml file. * .travis.yml file is out of date, auto-updating .travis.yml file. * .travis.yml file is out of date, auto-updating .travis.yml file. * .travis.yml file is out of date, auto-updating .travis.yml file. * .travis.yml file is out of date, auto-updating .travis.yml file. * New config.ini.php setting: `tracking_requests_require_authentication_when_custom_timestamp_newer_than`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-> when token_auth is invalid (or not set) and
cdtis set with an old timestamp that require authentication, we should skip tracking the request instead of tracking it with the "current datetime".Context
Currently one can override the request datetime in a Tracking API request by setting
cdtparameter. see documentation: http://developer.piwik.org/api-reference/tracking-api#other-parameters-require-authentication-via-token_authAs discussed in #9939 when the
token_authis not correct, currently the request is tracked using the current date time. This actually create invalid data and hard to detect the issue (ie. many requests could be tracked at once when a device comes online and old data tracked).The text was updated successfully, but these errors were encountered: