New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show warning when paq.push is not initialized correctly #10889
Conversation
Updated PR to still track but also log a message |
afa449b
to
a903985
Compare
Updated PR again to not track when tracker is not initialized upfront |
|
There are plenty of reasons why it won't fully work just search for issues in the issue tracker that are related to order. Eg we create cookies even though we shouldn't , or create cookies wrong domain etc. I can't do anything else here. Happy to close PR and it just won't keep working for users. Here was suggestion on top for #10797 (comment) but I likely won't find any time to work on it |
Also see comments where we discussed it. Eg custom tracker plugins won't be working with it etc |
refs #10878
This is PR for Piwik 3 for #10888
To test use eg
Then initialize tracker after document was loaded via
_paq.push
. You will see a console message and no created tracker. When using _paq.push for tracking, the Tracker needs to be configured upfront. Otherwise bugs may occur.