Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix metric was not formatted #10887

Merged
merged 6 commits into from Dec 1, 2016
Merged

Fix metric was not formatted #10887

merged 6 commits into from Dec 1, 2016

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Nov 20, 2016

This is PR for Piwik 3, see PR for Piwik 2 https://github.com/piwik/piwik/pull/10886/files

In this case we had a plugin with conversion rate and abandoned rate. Only conversion rate got formatted (like 45%) when fetching a regular report where abandoned rate remained unformatted (like 0.55).

This is PR for Piwik 3, see PR for Piwik 2 https://github.com/piwik/piwik/pull/10886/files

 In this case we had a plugin with conversion rate and abandoned rate. Only conversion rate got formatted (like 45%) when fetching a regular report where abandoned rate remained unformatted (like 0.55).
@tsteur tsteur added Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. labels Nov 20, 2016
@tsteur tsteur modified the milestones: 2.17.2, 3.0.0, 3.0.0-b4 Nov 20, 2016
@mattab mattab merged commit d4f17b7 into 3.x-dev Dec 1, 2016
@mattab mattab deleted the metricsformatting3x branch December 1, 2016 01:14
tsteur added a commit that referenced this pull request Feb 12, 2017
Similar to #10887 makes sure the rate metrics are formatted in mobile app. I wonder if we should maybe simply change it to `'/.*_rate$/'` and then remove several of them? Would simplify it for the future and be faster
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants