Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manual update guide is partially wrong - command to update files only? #10885

Open
tsteur opened this issue Nov 20, 2016 · 1 comment
Open

Manual update guide is partially wrong - command to update files only? #10885

tsteur opened this issue Nov 20, 2016 · 1 comment
Labels
c: Website matomo.org For issues related to our matomo.org website. Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc.

Comments

@tsteur
Copy link
Member

tsteur commented Nov 20, 2016

http://piwik.org/docs/update/#the-manual-three-step-update

It is not needed to delete your old Piwik files before transferring the new ones. The new files should overwrite all the old files with the same names.

Files should be deleted first, but not the files of custom plugins. Otherwise they run into issues like #10884 and #10805

Maybe we could be better offering a command that accepts a path to a zip file, or a "update-files-only" command. Maybe even via UI. The command with the regular update logic would make sure to delete not needed files. This is for cases where people had a problem where one or two files were not updated or deleted etc. Of course the same problem could happen again and the same files might not be updated or deleted.

When updating manually, we would need to be able to show a list of which files need to be deleted. Not sure what best workflow would be, but people are running into these issues all the time and we get issues about these issues all the time.

@tsteur tsteur added the c: Website matomo.org For issues related to our matomo.org website. label Nov 20, 2016
@mattab
Copy link
Member

mattab commented Dec 6, 2016

  • Agreed it is much needed as this creates real bugs and many users would be affected.

  • Another proposal on top of your existing ones (command console, UI, showing files to delete during upgrade) could be to have a System check diagnostic issue a warning or even error if an unexpected file is found within Piwik filesystem (excluding marketplace plugins) ?

  • Btw maybe we should also fix Automatically delete non-expected files from the filesystem #11132

@mattab mattab added this to the 3.0.0 milestone Dec 6, 2016
@mattab mattab added Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical. labels Dec 6, 2016
@mattab mattab removed the Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical. label Oct 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: Website matomo.org For issues related to our matomo.org website. Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc.
Projects
None yet
Development

No branches or pull requests

2 participants