Fix goal metric processing for device type / model / brand #10873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgiehl
added
Needs Review
sgiehl
commented
Nov 15, 2016
| @@ -231,7 +231,7 @@ private function getVisitFieldsPersist() | |||
| $dimensions = VisitDimension::getAllDimensions(); | |||
|
|
|||
| foreach ($dimensions as $dimension) { | |||
| if ($dimension->hasImplementedEvent('onExistingVisit')) { | |||
| if ($dimension->hasImplementedEvent('onExistingVisit') || $dimension->hasImplementedEvent('onAnyGoalConversion')) { | |||
There was a problem hiding this comment.
Not sure it this is the correct solution.
Explanation why I've changed that:
I had following code in a visit dimension
public function onAnyGoalConversion(Request $request, Visitor $visitor, $action)
{
return $visitor->getVisitorColumn($this->columnName);
}
That didn't work properly, as the column didn't implement the onExistingVisit event (which simply isn't needed) and thus the property wasn't set for an existing visit.
Instead of this change here, I could also add an empty onExistingVisit event to the columns. But I think it is more useful this way.
sgiehl
force-pushed
the
fixdevicegoalmetrics
branch
from
4fb3be2
to
06d6e7b
Compare
|
Failing UI tests seem not to be related to this PR. |
|
LGTM. I'll confirm on demo3 in coming days when the reports work 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Processing goal metrics for device type / model / brand was not working properly.
The visitor column value was not available when processing the goal conversion, which should be fixed with this changes.
I've also added some small tests to prove the goal metrics are processed correctly for device type / brand / model.
fixes #9777