Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI test Overlay_page_new_links regressed #10869

Closed
mattab opened this issue Nov 15, 2016 · 3 comments
Closed

UI test Overlay_page_new_links regressed #10869

mattab opened this issue Nov 15, 2016 · 3 comments
Assignees
@sgiehl
Labels
c: Tests & QA For issues related to automated tests or making it easier to QA & test issues. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Milestone
3.0.1

Comments

@mattab
Copy link
Member

mattab commented Nov 15, 2016

See discussion in: #10842

The UI test Overlay_page_new_links / page_new_links does not work about since this PR was merged #10580

See for example at: http://builds-artifacts.piwik.org/piwik/piwik/new_submoduels/20945/Overlay_page_new_links.png

diff
@mattab mattab added the c: Tests & QA For issues related to automated tests or making it easier to QA & test issues. label Nov 15, 2016
@mattab mattab added this to the 3.0.0 milestone Nov 15, 2016
@mattab mattab modified the milestones: 3.0.1, 3.0.0 Dec 18, 2016
@sgiehl
Copy link
Member

sgiehl commented Dec 30, 2016

Seems this one is already fixed somehow... latest process screenshot looks correct http://builds-artifacts.piwik.org/piwik/piwik/3.x-dev/21730/processed/Overlay_page_new_links.png

@mattab
Copy link
Member Author

mattab commented Dec 30, 2016 •
edited

But the expected one doesn't: https://github.com/piwik/piwik/blob/3.x-dev/tests/UI/expected-screenshots/Overlay_page_new_links.png

do you know why tests are passing anyway?

@sgiehl sgiehl mentioned this issue Dec 30, 2016
Merged
@sgiehl
Copy link
Member

sgiehl commented Dec 30, 2016

Test was changed to check for "similar" image. I'll remove that...

@sgiehl sgiehl self-assigned this Dec 30, 2016
@sgiehl sgiehl closed this as completed in d58200d Dec 30, 2016
@mattab mattab added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Jan 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sgiehl sgiehl

Labels
c: Tests & QA For issues related to automated tests or making it easier to QA & test issues. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
3.0.1
Development

No branches or pull requests
2 participants
@mattab @sgiehl