Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete scheduled report after it was sent as scheduled #10863

Merged
merged 2 commits into from Nov 30, 2016
Merged

Delete scheduled report after it was sent as scheduled #10863

merged 2 commits into from Nov 30, 2016

Conversation

mattab
Copy link
Member

@mattab mattab commented Nov 14, 2016

Fixes #10788

@mattab mattab added the Needs Review PRs that need a code review label Nov 14, 2016
@mattab mattab added this to the 3.0.0-b4 milestone Nov 14, 2016
tsteur
tsteur reviewed Nov 14, 2016
View reviewed changes
plugins/ScheduledReports/API.php
@chmod($outputFilename, 0600);
@unlink($outputFilename);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use Filesystem::deleteFileIfExists ? Always good to use our own API's so changes can be made in one place if needed. Is the chmod needed at all? Is it in case the file was not deleted?

@mattab
Copy link
Member Author

mattab commented Nov 30, 2016

applied your feedback @tsteur

@mattab mattab merged commit c92e596 into 3.x-dev Nov 30, 2016
@mattab mattab deleted the delete_report_on_disk branch November 30, 2016 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsteur tsteur tsteur left review comments

Assignees
No one assigned
Labels
Needs Review PRs that need a code review
Projects
None yet
Milestone
3.0.0-b4
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mattab @tsteur