Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated PIWIK_AUTOMATION encrypted token #10847

Merged
merged 1 commit into from Nov 14, 2016

Conversation

mattab
Copy link
Member

@mattab mattab commented Nov 9, 2016

can be merged if build is green

it was introduced in d57f4a8
and then deprecated with git-lfs in #8392

was introduced in d57f4a8 
but deprecated with git lfs #8392
@mattab mattab added the Needs Review PRs that need a code review label Nov 9, 2016
@mattab mattab added this to the 3.0.0-b3 milestone Nov 9, 2016
@tsteur
Copy link
Member

tsteur commented Nov 13, 2016

"test_piwikJs_minified_isUpToDate " https://travis-ci.org/piwik/piwik/jobs/174599441#L789 is failing but shouldn't be related to this change.

I have restarted a UI job as it did not complete. Looks like screenshot uploads still work. Not sure if it was used for something else.

LGTM 👍

@mattab mattab merged commit 7c1590b into 3.x-dev Nov 14, 2016
@mattab mattab deleted the remove_deprecated_token branch November 14, 2016 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants