Update title #10834
Update title #10834
Conversation
| {%- if categoryTitle is defined %}{{ categoryTitle }} - {% endif %} | ||
| {%- if not isCustomLogo %}Piwik{% endif %} | ||
| {% set branding = isCustomLogo ? '' : 'Piwik' %} | ||
| {{ [title, categoryTitle, branding]|join(' - ')|trim('- ') }} |
There was a problem hiding this comment.
I am getting here an error when categoryTitle is not defined
There was a problem hiding this comment.
added default filter, see new commit
Add default filter
| {%- if categoryTitle is defined %}{{ categoryTitle }} - {% endif %} | ||
| {%- if not isCustomLogo %}Piwik{% endif %} | ||
| {% set branding = isCustomLogo ? '' : 'Piwik' %} | ||
| {{ [title, categoryTitle|default, branding]|join(' - ')|trim('- ') }} |
There was a problem hiding this comment.
I now see that there was before a check for title is defined so I'm now thinking the title might not be defined sometimes as well. To you mind adding a title|default('')?
I'm wondering if it would actually work when title and category title is not defined? Wouldn't it be maybe something like - - Piwik because it first starts with a whitespace and would be maybe not trimmed because of that? Maybe needs another trim(' - ') ?
|
BTW I have sent you an email recently. Not sure if I used right email address. Feel free to get in touch otherwise via hello at piwik.org :) |
Suggestion for #10833