@sgiehl opened this Pull Request on November 2nd 2016 Member

Setting the used location provider is currently done in a controller action, which is called from the admin page.

Moving that method to the API has the advantage that the provider could be set without using the UI. And it will be possible to hook into the API call using the default API events like API.UserCountry.setLocationProvider.end to handle something that should be done after the location provider has changed. Might be useful for some plugins.

@mattab commented on November 3rd 2016 Member

Good idea, just need to restore the dieIfGeolocationAdminIsDisabled feature and maybe few tests

@sgiehl commented on November 3rd 2016 Member

Added the check for configuration and some more tests. Is it good to merge then?

This Pull Request was closed on November 8th 2016
Powered by GitHub Issue Mirror