Move method for setting location provider from controller to api #10828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattab
reviewed
Nov 3, 2016
| LocationProvider::getAllProviders(); | ||
| } | ||
|
|
||
| public function test_setLocationProvider() |
There was a problem hiding this comment.
I guess we need tests for:
- user is not super user -> exception
- provider is invalid -> exception
- dieIfGeolocationAdminIsDisabled was removed but is needed -> when !UserCountry::isGeoLocationAdminEnabled() then we should not allow even super user to modify the provider (to maintain the config setting
enable_geolocation_admin = 1working as expected)
|
Good idea, just need to restore the |
sgiehl
force-pushed
the
locationproviderapi
branch
from
20c42f9
to
867e983
Compare
|
Added the check for configuration and some more tests. Is it good to merge then? |
sgiehl
force-pushed
the
locationproviderapi
branch
from
867e983
to
ee03ee1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting the used location provider is currently done in a controller action, which is called from the admin page.
Moving that method to the API has the advantage that the provider could be set without using the UI. And it will be possible to hook into the API call using the default API events like
API.UserCountry.setLocationProvider.endto handle something that should be done after the location provider has changed. Might be useful for some plugins.