Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show more ways of how users can donate #10822

Merged
merged 2 commits into from Nov 3, 2016
Merged

Show more ways of how users can donate #10822

merged 2 commits into from Nov 3, 2016

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Nov 1, 2016

ping @mattab

@tsteur tsteur added the Needs Review PRs that need a code review label Nov 1, 2016
@tsteur tsteur added this to the 2.17.1 milestone Nov 1, 2016
@tsteur
Copy link
Member Author

tsteur commented Nov 1, 2016

@sgiehl as I have added more parameters to the translation string. Will it still invalidate the language key for other languages?

@sgiehl
Copy link
Member

sgiehl commented Nov 1, 2016

All changes to a string will invalidate all translations for it on transifex. But it won't affect anything in 2.x as we won't do any more translations updates there.

@tsteur
Copy link
Member Author

tsteur commented Nov 1, 2016

though so. I will update the PR to use a new translation key

@mattab mattab merged commit bc5dabb into 2.x-dev Nov 3, 2016
@mattab mattab deleted the donatewidget branch November 3, 2016 02:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants