Removes deprecated methods #10815
Removes deprecated methods #10815
Conversation
sgiehl
added
not-in-changelog
sgiehl
force-pushed
the
removedeprecatedmenuadd
branch
from
68458c0
to
1770e7b
Compare
sgiehl
force-pushed
the
removedeprecatedmenuadd
branch
from
55998c4
to
43c75a1
Compare
|
We should keep Some tests are failing. Once merged we need to release new versions of the plugins on the Marketplace and require Piwik 3b3 |
|
Updated the plugins. Requiring 3b3 in the new plugin versions wasn't required, as the changes should work with all 3.x versions. |
|
True, the new menu methods already existed before so no need to require new version 👍 |
|
Last build, with updated submodules, had "only" failing UI tests. But those are also failing on 3.x-dev branch... |
|
Sweet, feel free to merge 👍 |
|
|
||
| public function renameUserSettingsModuleAndAction(&$module, &$action) | ||
| { | ||
| if ($module == 'UserSettings' && $action == 'getPlugin') { |
There was a problem hiding this comment.
@sgiehl why removing this as well, as it would break Embed widgets and is not needed to deprecate IMHO
| @@ -23,7 +23,6 @@ public function registerEvents() | |||
| { | |||
| return array( | |||
| 'Live.getAllVisitorDetails' => 'extendVisitorDetails', | |||
| 'Request.getRenamedModuleAndAction' => 'renameUserSettingsModuleAndAction', | |||
There was a problem hiding this comment.
We had marked them as to be removed from Piwik 3
There was a problem hiding this comment.
Not sure why it was marked that way, as IMO there is no value to removing these calls. there is no code complexity involved for us, but as a result we would force people to change some URLs deep into their app or product... which would be time consuming for them
| @@ -23,7 +23,6 @@ public function registerEvents() | |||
| { | |||
| return array( | |||
| 'Live.getAllVisitorDetails' => 'extendVisitorDetails', | |||
| 'Request.getRenamedModuleAndAction' => 'renameUserSettingsModuleAndAction', | |||
There was a problem hiding this comment.
idem for all 'Request.getRenamedModuleAndAction' listeners
As tests are currently failing due to not removed deprecated methods, I had a quick look and removed the methods we had tests for.
I only didn't remove/replace the method
Plugin::getListHooksRegistered()as the removal was announced for Piwik 4 in changelog. Have adjusted the test in that case. Or shall we remove that for Piwik 3?Also opened matomo-org/plugin-TasksTimetable#10 and matomo-org/plugin-SecurityInfo#17 to fix the plugins as they were still using
Menu::add()