Migrate Goal plugin update script to use Migration Factory #10808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgiehl
added
not-in-changelog
tsteur
reviewed
Oct 30, 2016
| $updateSql = 'ALTER TABLE `' . Common::prefixTable('goal'). '` ADD COLUMN `description` VARCHAR(255) NOT NULL DEFAULT \'\' AFTER `name`;'; | ||
|
|
||
| return array( | ||
| $this->migration->db->sql($updateSql, Updater\Migration\Db::ERROR_CODE_DUPLICATE_COLUMN) |
sgiehl
force-pushed
the
migrategoalupdatescript
branch
from
ae9c984
to
8009c53
Compare
|
Feel free to merge once tests ran 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in comment here: ab3eba1#commitcomment-19183659
Goal plugin update script now uses Migration Factory