New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
How do I git clone without fetching the hundreds of piwik UI screenshot tests files? #10802
Comments
We used to store the screenshots in a seprate repo. But the screenshots are now stored within this repo using Git LFS |
@jurgenhaas which guidelines are you referring to? We should definitely update the guide. @sgiehl is there maybe a way to fetch / clone the repository and ignoring all images in git lfs? Maybe we could document this as well. May be useful eg here: http://piwik.org/faq/how-to-install/faq_18271/ |
See git-lfs/git-lfs#720 |
Here is an interesting performance comparison: git-lfs/git-lfs#931 (comment) I will give them a try and meanwhile reopen the issue |
They all took about the same time for me and I think we could recommend any of them. @jurgenhaas can you try if |
@tsteur I've found the mention about screenshot storage at https://github.com/piwik/piwik/tree/3.x-dev/tests#screenshot-tests-build-artifacts I will test the various clone options right now and will report back shortly. |
@tsteur The filter config option is working well, it brings back the previous performance and the good thing is that this config is persistent because it is written to If someone uses this as a deployment strategy, the command should look like this:
|
@jurgenhaas the link you mentioned references actually generated screenshots during the test runs but not expected screenshots that are already in the repository. Thank you for your test and feedback 👍 I have updated https://piwik.org/faq/how-to-install/faq_18271/ |
Looks like that happened by mistake and cloning the repository now takes ages. Reading the guidelines I thought the screenshots shot be stored at a different place.
The text was updated successfully, but these errors were encountered: