Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How do I git clone without fetching the hundreds of piwik UI screenshot tests files? #10802

Closed
jurgenhaas opened this issue Oct 28, 2016 · 8 comments
Assignees
Labels
answered For when a question was asked and we referred to forum or answered it. c: Website matomo.org For issues related to our matomo.org website.
Milestone

Comments

@jurgenhaas
Copy link

Looks like that happened by mistake and cloning the repository now takes ages. Reading the guidelines I thought the screenshots shot be stored at a different place.

@sgiehl
Copy link
Member

sgiehl commented Oct 30, 2016

We used to store the screenshots in a seprate repo. But the screenshots are now stored within this repo using Git LFS

@sgiehl sgiehl closed this as completed Oct 30, 2016
@sgiehl sgiehl added the answered For when a question was asked and we referred to forum or answered it. label Oct 30, 2016
@tsteur
Copy link
Member

tsteur commented Oct 30, 2016

@jurgenhaas which guidelines are you referring to? We should definitely update the guide.

@sgiehl is there maybe a way to fetch / clone the repository and ignoring all images in git lfs? Maybe we could document this as well. May be useful eg here: http://piwik.org/faq/how-to-install/faq_18271/

@sgiehl
Copy link
Member

sgiehl commented Oct 30, 2016

See git-lfs/git-lfs#720
Haven't tried that, but might be an option

@tsteur
Copy link
Member

tsteur commented Oct 30, 2016

Here is an interesting performance comparison: git-lfs/git-lfs#931 (comment) I will give them a try and meanwhile reopen the issue

@tsteur tsteur reopened this Oct 30, 2016
@tsteur
Copy link
Member

tsteur commented Oct 30, 2016

They all took about the same time for me and I think we could recommend any of them.

@jurgenhaas can you try if git clone --config filter.lfs.smudge=true https://github.com/piwik/piwik.git is faster for you? Or alternatively GIT_LFS_SKIP_SMUDGE=1 git clone https://github.com/piwik/piwik.git ?

@tsteur tsteur added c: Website matomo.org For issues related to our matomo.org website. and removed answered For when a question was asked and we referred to forum or answered it. labels Oct 30, 2016
@jurgenhaas
Copy link
Author

@tsteur I've found the mention about screenshot storage at https://github.com/piwik/piwik/tree/3.x-dev/tests#screenshot-tests-build-artifacts

I will test the various clone options right now and will report back shortly.

@jurgenhaas
Copy link
Author

@tsteur The filter config option is working well, it brings back the previous performance and the good thing is that this config is persistent because it is written to .git/config. All the screenshots are zero-length files and the only small downside is that the git status is dirty.

If someone uses this as a deployment strategy, the command should look like this:

git clone -b 2.17.0 --recurse-submodules --config filter.lfs.smudge=true https://github.com/piwik/piwik.git

@tsteur
Copy link
Member

tsteur commented Nov 1, 2016

@jurgenhaas the link you mentioned references actually generated screenshots during the test runs but not expected screenshots that are already in the repository.

Thank you for your test and feedback 👍 I have updated https://piwik.org/faq/how-to-install/faq_18271/

@tsteur tsteur closed this as completed Nov 1, 2016
@tsteur tsteur added this to the 2.17.1 milestone Nov 1, 2016
@tsteur tsteur self-assigned this Nov 1, 2016
@mattab mattab changed the title All test/UI screenshots are in the git repository How do I git clone without fetching the hundreds of piwik UI screenshot tests files? Nov 3, 2016
@mattab mattab added the answered For when a question was asked and we referred to forum or answered it. label Nov 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
answered For when a question was asked and we referred to forum or answered it. c: Website matomo.org For issues related to our matomo.org website.
Projects
None yet
Development

No branches or pull requests

4 participants