Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Event_Dispatcher to 1.1 #1080

Closed
pebosi opened this issue Dec 15, 2009 · 3 comments
Closed

Update Event_Dispatcher to 1.1 #1080

pebosi opened this issue Dec 15, 2009 · 3 comments
Labels
Bug For errors / faults / flaws / inconsistencies etc. wontfix If you can reproduce this issue, please reopen the issue or create a new one describing it.
Milestone
0.5.3

Comments

@pebosi
Copy link
Contributor

pebosi commented Dec 15, 2009

Here's a patch updating Event_Dispatcher from http://pear.php.net/package/Event_Dispatcher/download/ to Version 1.1
@pebosi
Copy link
Contributor Author

pebosi commented Dec 15, 2009

Attachment:
piwik-event1.1.patch

@mattab
Copy link
Member

mattab commented Dec 15, 2009

I had to modify the code to make it php 5 STRICT mode compatible. the 1.1 seems to have issues with strict mode. I'm ok having an old version considering how simple and stable this lib is

@robocoder
Copy link
Contributor

Ditto on the wontfix.

I made changes too.

The other diffs (lines 125-128, 156 and 249) are all php4-related (syntax or performance).

@pebosi pebosi added this to the Piwik 0.5.3 milestone Jul 8, 2014
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug For errors / faults / flaws / inconsistencies etc. wontfix If you can reproduce this issue, please reopen the issue or create a new one describing it.
Projects
None yet
Milestone
0.5.3
Development

No branches or pull requests
3 participants
@pebosi @mattab @robocoder