Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix script tag is not closed when generating tracker code and custom tracker plugin is installed #10792

Merged
merged 2 commits into from Nov 3, 2016
Merged

Fix script tag is not closed when generating tracker code and custom tracker plugin is installed #10792

merged 2 commits into from Nov 3, 2016

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Oct 26, 2016

Ping @mattab

This will be needed in 2.17.1

@tsteur tsteur added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Oct 26, 2016
@tsteur tsteur added this to the 2.17.1 milestone Oct 26, 2016
@tsteur tsteur added Needs Review PRs that need a code review and removed not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. labels Oct 26, 2016
@tsteur tsteur changed the title Fix script tag is not closed Fix script tag is not closed when generating tracker code and custom tracker plugin is installed Oct 26, 2016
@mattab mattab merged commit 74ddd08 into 2.x-dev Nov 3, 2016
@mattab mattab deleted the missing_script_close branch November 3, 2016 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Needs Review PRs that need a code review
Projects
None yet
Milestone
2.17.1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tsteur @mattab