Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Marketplace plugin didn't get enabled during 2.17.0-b2 update #10778

Closed
mattab opened this issue Oct 22, 2016 · 2 comments
Closed

Marketplace plugin didn't get enabled during 2.17.0-b2 update #10778

mattab opened this issue Oct 22, 2016 · 2 comments
Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Milestone
2.17.0

Comments

@mattab
Copy link
Member

mattab commented Oct 22, 2016

seen on demo.piwik.org
@mattab mattab added this to the 2.17.0 milestone Oct 22, 2016
@mattab mattab added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Oct 22, 2016
@mattab
Copy link
Member Author

mattab commented Oct 22, 2016

it's because, when the 2.17.0 upgrade runs, the enable_marketplace setting was already removed from the global.ini.php and the upgrade thinks that it was set to 0, and that marketplace should not be enabled. Instead we should check the config setting is exactly 0 (and not null)

mattab added a commit that referenced this issue Oct 22, 2016
@mattab
enable_marketplace should be set specifically to 0 (if it's null then…
30a25ec 
… we consider marketplace is enabled)

fixes  #10778
@mattab
Copy link
Member Author

mattab commented Oct 22, 2016

fixed, will now release 2.17.0-b3

@mattab mattab closed this as completed Oct 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
2.17.0
Development

No branches or pull requests
1 participant
@mattab