Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LanguagesManagerTest::testGetTranslationsForLanguages test sometimes fail with " Exception: unable to save empty or invalid translations" #10774

Closed
mattab opened this issue Oct 21, 2016 · 3 comments
Closed

LanguagesManagerTest::testGetTranslationsForLanguages test sometimes fail with " Exception: unable to save empty or invalid translations" #10774

mattab opened this issue Oct 21, 2016 · 3 comments
Assignees
@sgiehl
Labels
c: Tests & QA For issues related to automated tests or making it easier to QA & test issues.
Milestone
Backlog (Help wan...

Comments

@mattab
Copy link
Member

mattab commented Oct 21, 2016

this translation file da063f9 (before it was deleted)

caused this build job to fail: https://travis-ci.org/piwik/piwik/jobs/169435535

with error

1) Piwik\Plugins\LanguagesManager\Test\Integration\LanguagesManagerTest::testGetTranslationsForLanguages with data set #1288 ('hr', 'CorePluginsAdmin')

Exception: unable to save empty or invalid translations

/home/travis/build/piwik/piwik/plugins/LanguagesManager/TranslationWriter/Writer.php:268

/home/travis/build/piwik/piwik/plugins/LanguagesManager/Test/Integration/LanguagesManagerTest.php:99

Thoughts?
@mattab mattab added the c: Tests & QA For issues related to automated tests or making it easier to QA & test issues. label Oct 21, 2016
@mattab mattab added this to the 3.0.0 milestone Oct 21, 2016
@sgiehl
Copy link
Member

sgiehl commented Oct 25, 2016 via email

@sgiehl
Copy link
Member

sgiehl commented Oct 29, 2016

Had a look right now. Seems to be exactly what I supposed. The file would have been empty after clearing it. We could catch that exception in the tests and output a message that the file might need to be removed?

@sgiehl sgiehl closed this as completed in 646abea Oct 30, 2016
@sgiehl
Copy link
Member

sgiehl commented Oct 30, 2016

In the future those tests will now also be skipped and a proper message will be given

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sgiehl sgiehl

Labels
c: Tests & QA For issues related to automated tests or making it easier to QA & test issues.
Projects
None yet
Milestone
Backlog (Help wanted)
Development

No branches or pull requests
2 participants
@mattab @sgiehl