Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

when a plugin modifies piwik.js the system check will show a warning "File size mismatch: /storage/divezone/www/piwik/piwik.js (expected length: X, found: Y)" #10755

Closed
mattab opened this issue Oct 18, 2016 · 1 comment
Closed

when a plugin modifies piwik.js the system check will show a warning "File size mismatch: /storage/divezone/www/piwik/piwik.js (expected length: X, found: Y)" #10755

mattab opened this issue Oct 18, 2016 · 1 comment
Assignees
@tsteur
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Milestone
2.17.0

Comments

@mattab
Copy link
Member

mattab commented Oct 18, 2016 •
edited

When a plugin hooks into the platform and injects code into the Piwik JavaScript tracker code piwik.js (a feature introduced in #10270), the system check displays a warning that the File integrity failed on the piwik.js file.

Maybe, when a plugin is activated and known to update the piwik.js, we could display a "green notice" such as "Piwik.js has been modified from the default piwik.js - which is likely expected since you use the plugin XYZ which modifies piwik.js"

what do you think? cc @tsteur

file integrity
@mattab mattab added this to the 2.17.0 milestone Oct 18, 2016
tsteur added a commit that referenced this issue Oct 18, 2016
@tsteur
fixes #10755 Fix integrity filecheck may falsely mark piwikjs as invalid
f455215
This was referenced Oct 18, 2016
Merged
Merged
@tsteur tsteur self-assigned this Oct 18, 2016
@tsteur tsteur added the Bug For errors / faults / flaws / inconsistencies etc. label Oct 18, 2016
mattab pushed a commit that referenced this issue Oct 20, 2016
@tsteur @mattab
fixes #10755 Fix integrity filecheck may falsely mark piwikjs as inva…
cbf4a83 
…lid (#10763)
@mattab
Copy link
Member Author

mattab commented Oct 22, 2016

This was fixed in #10763

@mattab mattab closed this as completed Oct 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tsteur tsteur

Labels
Bug For errors / faults / flaws / inconsistencies etc.
Projects
None yet
Milestone
2.17.0
Development

No branches or pull requests
2 participants
@tsteur @mattab