Make sure to create a dropdown menu when there are more than 5 entries in a sub-menu #10751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsteur
commented
Oct 18, 2016
| @@ -134,6 +134,14 @@ | |||
| } | |||
| }); | |||
|
|
|||
| if ('undefined' !== typeof $scope.placeholder && $scope.placeholder !== null) { | |||
There was a problem hiding this comment.
this is a bit off topic sorry. It makes sure to show correct placeholder when changing the value of the placeholder attribute
mattab
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When there are more than 5 entries of the same type such as goals or dashboards, we create a dropdown menu and group them together. There used to be an API to do this in Piwik 2 but we have removed the reporting menu API so the API to do this no longer existed. This PR brings this feature back without the developer having to do anything. It now works just automatically.