Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When clicking on a related report, update report title and help #10750

Merged
merged 1 commit into from Oct 30, 2016
Merged

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Oct 17, 2016

fixes #10745

This works on reporting pages. When the widget is exported we do not show a title anyway, when viewing it in the dashboard, the widget title stays which should be the case probably.

It also updates the report documentation and the feature name for the rating feature. We do not update a help url or edit url.

This PR is specifically to change behaviour in a reporting page only.

@tsteur tsteur added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels Oct 17, 2016
@tsteur tsteur added this to the 3.0.0-b2 milestone Oct 17, 2016

var $title = $headline.find('.title:not(.ng-hide)');
if ($title.size()) {
$title.text(relatedReportName);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a bit hacky but there is currently not really a different way unless we move visualizations to angular as well (instead of rendering them in twig)

@@ -1753,22 +1782,8 @@ $.extend(DataTable.prototype, UIControl.prototype, {
relatedReports.each(function () {
var clicked = this;
$(this).unbind('click').click(function (e) {
var url = $(this).attr('href');
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed this code and removed it as it is no longer working and I think not needed.

@tsteur tsteur merged commit bf3cde0 into 3.x-dev Oct 30, 2016
@tsteur tsteur deleted the 10745 branch October 30, 2016 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When clicking on a related report, the report title in a reporting page should be updated
1 participant