Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement regional changes of France in geoipregionvars.php #10749

Closed
Fensterbank opened this issue Oct 17, 2016 · 3 comments
Closed

Implement regional changes of France in geoipregionvars.php #10749

Fensterbank opened this issue Oct 17, 2016 · 3 comments
Labels
answered For when a question was asked and we referred to forum or answered it.
Milestone
Backlog (Help wan...

Comments

@Fensterbank
Copy link
Contributor

Since 2016 some regions changed in France, e.g. Grand Est is a new region merged from Alsace, Champagne-Ardenne and Lorraine.
These changes should be implemented in geoipregionvars.php and in the region map of france.
@mattab
Copy link
Member

mattab commented Nov 11, 2016

Thanks for the suggestion @Fensterbank - maybe you are able to make a pull request? would be great!

@mattab mattab added this to the Mid term milestone Nov 11, 2016
@Fensterbank
Copy link
Contributor Author

I don't think it can be done by me easily. The map has to be updated and what's happening with old visits referenced to old regions?
Just updating geoipregionvars.php would screw everything up.

Unfortunately I don't have the free time to dig deep into this topic, just noticed the issue.

@mattab
Copy link
Member

mattab commented Mar 19, 2019

Geoip2 is using the new french regions correctly 👍
next we would need to update the Map to show the regions correctly (currently regions are only shown correctly in the normal reports, tables/graphs and not in the country map)

@mattab mattab closed this as completed Mar 19, 2019
@mattab mattab added the answered For when a question was asked and we referred to forum or answered it. label Mar 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
answered For when a question was asked and we referred to forum or answered it.
Projects
None yet
Milestone
Backlog (Help wanted)
Development

No branches or pull requests
2 participants
@mattab @Fensterbank