Marketplace improvements #10737
Merged
Marketplace improvements #10737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsteur
added
c: Marketplace
|
@sgiehl do you have an idea why |
Conflicts: tests/UI/expected-screenshots/UIIntegrationTest_admin_plugins.png tests/UI/expected-screenshots/UIIntegrationTest_admin_themes.png tests/UI/expected-screenshots/UIIntegrationTest_api_listing.png
Conflicts: tests/UI/expected-screenshots/UIIntegrationTest_admin_plugins.png tests/UI/expected-screenshots/UIIntegrationTest_admin_themes.png tests/UI/expected-screenshots/UIIntegrationTest_api_listing.png
mattab
reviewed
Oct 21, 2016
| @@ -20,9 +20,18 @@ class Menu extends \Piwik\Plugin\Menu | |||
| { | |||
| private $marketplacePlugins; | |||
There was a problem hiding this comment.
@tsteur as there are now such nice and complete UI tests & fixture for the Marketplace, would it maybe be do-able to add a single UI test for this " counter-plugins-to-update displayed-in-menu" feature?
|
Updated the only FAQ that mentioned enable_marketplace: How do I configure Piwik on a server without Internet? |
This was referenced Oct 22, 2016
mattab
added
the
Major
mattab
reviewed
Oct 22, 2016
|
|
||
| return array( | ||
| 'MarketplaceEndpoint' => function (ContainerInterface $c) { | ||
| // if you wonder why this here is configured here again, and the same as in `config.php`, |
|
So much code, so many tests... beautifully hand crafted quality software! This Epic pull request 💥 is going to be merged NOW! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #10695
This update brings many new features:
multi_server_environmentto specify whether Piwik is running in a multi server environment. If so, we disable some features like installing plugins from the Marketplace directly as it would be only installed on one server instead of all of them. Instead they are able to download. Same for plugin updates. This will be also useful later for things that changes config entries etc[General]enable_marketplace=0/1is now disabled and instead we are using the plugin enabled/activated to disable the Marketplace. The updater respects a setting where the Marketplace is already disabled and it won't enable the Marketplace in this case$coreUpdater->isUpdatingOverHttps())