#2137 flatten email/pdf reports #10722
Conversation
|
Pull Request WIP - done |
…rrors when displayFlat isn't yet set in the Database record of a report.
…ewly added checkbox for flattening reports in the reports-generation form.
mattab
added
Pull Request WIP
|
@mattab the 'Pull Request WIP' can be removed: I've tested my requirements and removed all side-effects. The Feature is also included in the UI-Test (new Checkbox "Flatten" in addReport mask). I'll stand by to fix and adjust anything you find during review. |
…'s supposed to.
cbuchli
force-pushed
the
feature/2137_3.x-dev_flattenEmailReports
branch
from
10a4a76
to
e5ca9a6
Compare
| <div piwik-field uicontrol="checkbox" | ||
| name="display_flat" | ||
| ng-model="manageScheduledReport.report.displayFlat" | ||
| title="{{ 'General_Flatten'|translate|e('html_attr') }}"> |
There was a problem hiding this comment.
I wonder if it is enough to show "Flatten" or whether could explain a little. Like Flatten will be only applied to reports that support it, and by default it is shown "hierarchical". Although I think in reports it is not really shown hierarchical by default but only the first level of the report which is not really useful so flatten is quite valuable. I think we need to explain it to users. @mattab maybe an idea?
|
Worked for me and is useful 👍 Only need to work a little on the wording in the UI I'd say |
tsteur
removed
the
Pull Request WIP
|
I'm looking forward to see this merged. 👍 |
|
After testing UI and thinking about all reports that support Flatten, now it feels like we should keep things even more simple while trying to be useful to most people...so i'd go even further and enable flatten for all reports by default, and not make it configurable. So far i could not think of a use case where you'd want the reports hierarchical... can't believe it took us so long to address this! if the need to have it configurable would come up, we could re-use your PR. I'll open a separate PR and close this one. thanks for creating it and hope you will check out some other issues 👍 |
Adds a new Flag to Scheduled Reports that makes it possible to flatten the generated reports.
The behaviour is 100% backwards compatible and doesn't need any update-scripts to be run since the default is set to false and the flag isn't marked as mandatory. It's stored in the report's parameters field and thus doesn't change the DB-Scheme neither.
Resolves #2137 in a "quickfix" manner.
Feature supported by EDA Switzerland