Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed GitHub case #10713

Merged
merged 1 commit into from Oct 9, 2016
Merged

Fixed GitHub case #10713

merged 1 commit into from Oct 9, 2016

Conversation

lipis
Copy link
Contributor

@lipis lipis commented Oct 7, 2016

No description provided.

@lipis
Copy link
Contributor Author

lipis commented Oct 7, 2016

screen shot 2016-10-07 at 13 16 22

I wanted to find/change that one.. but I'm guessing it's from another service :)

@lipis
Copy link
Contributor Author

lipis commented Oct 7, 2016

not sure why this is failing..

@tsteur
Copy link
Member

tsteur commented Oct 9, 2016

Thanks for that 👍 Very appreciated

@tsteur tsteur merged commit e3b2504 into matomo-org:3.x-dev Oct 9, 2016
@lipis lipis deleted the GitHub branch October 9, 2016 19:06
@lipis
Copy link
Contributor Author

lipis commented Oct 9, 2016

But where can I find the Github that is appearing on the chart?

@sgiehl
Copy link
Member

sgiehl commented Oct 9, 2016

This is in https://github.com/piwik/searchengine-and-social-list/blob/master/Socials.yml
But changing that wouldn't update already tracked data and so it would also effect statistics.
Evolution charts would show historical data for 'Github' but no ongoing data, where as 'GitHub' would start to be tracked - having no historical data

@tsteur
Copy link
Member

tsteur commented Oct 9, 2016

@tsteur
Copy link
Member

tsteur commented Oct 9, 2016

@sgiehl maybe we could use the GroupBy filter in the API there? Would be great to still have correct numbers independent of case

@lipis
Copy link
Contributor Author

lipis commented Oct 9, 2016

I agree with @tsteur the grouping should not be depended on the case..

@sgiehl
Copy link
Member

sgiehl commented Oct 9, 2016

Guess that would be a possibility, but keep in mind, that the social definitions are updated in all existing piwik using a task. So it would be broken there until Piwik was updated

@lipis
Copy link
Contributor Author

lipis commented Oct 9, 2016

I understand how programming works..

@mattab mattab added this to the 3.0.0-b2 milestone Oct 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants