Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retry loading a widget up to three times in case of error #10704

Closed
wants to merge 1 commit into from

Conversation

fhoech
Copy link

@fhoech fhoech commented Oct 6, 2016

Widgets timing out seems to be a relative common problem, especially if many of them are displayed at once.

Widgets timing out seems to be a relative common problem, especially if many of them are displayed at once.
@mattab mattab added this to the 3.0.0-b4 milestone Nov 11, 2016
@mattab mattab added the Needs Review PRs that need a code review label Nov 11, 2016
@mattab mattab modified the milestones: 3.0.0-b4, 3.0.0-b5 Nov 30, 2016
@mattab
Copy link
Member

mattab commented Nov 30, 2016

Thank you @fhoech for the PR!

When you experience this "Widget times out" issue, is it when viewing reports for "Today" or "current month / week" or a date range, including today? (maybe this could be caused by this bug: #8444 which we ideally should fix differently ie. introduce a lock so that other widgets "wait" for the main process to finish archiving)

Or do you maybe also experience this issue on older reports that do not include today?

@mattab mattab modified the milestones: 3.0.0, 3.0.0-b5 Dec 5, 2016
@mattab
Copy link
Member

mattab commented Dec 5, 2016

@fhoech do you have a chance to answer #10704 (comment) ? thanks!

@fhoech
Copy link
Author

fhoech commented Dec 5, 2016

When you experience this "Widget times out" issue, is it when viewing reports for "Today" or "current month / week" or a date range, including today?

It can happen for any range as far as I've experienced it, but I've not checked if "Today" needs to be part of the range for the problem to manifest or not (I'm using log analytics exclusively, and the log import and report generation runs in a daily cronjob, but I've still enabled "generate reports on the fly" or however the option is called in the piwik admin interface).

maybe this could be caused by this bug: #8444

I haven't checked but from the sounds of it, that could be it.

@mattab
Copy link
Member

mattab commented May 16, 2017

@sgiehl @tsteur any thoughts on this PR? Seems like it could be useful, yet maybe would hide the actual problem. Not decided yet what to do (merge or close) and need your input

@tsteur
Copy link
Member

tsteur commented May 16, 2017

I'm not sure either. I would max retry it a second date and maybe make it dependent on date (maybe only for ranges and when it includes today or so?).

It is hiding the problem a little and likely the solution is to disable browser archiving and the problem won't occur anymore (unless it is memory related but then retrying won't solve it). Possibly I would rather prefer to better educate and mention disabling browser archiving if it is enabled.

@sgiehl
Copy link
Member

sgiehl commented May 16, 2017

Possibly I would rather prefer to better educate and mention disabling browser archiving if it is enabled.

I think that would be a better solution. So I vote for not merging

@mattab mattab closed this May 17, 2017
@mattab
Copy link
Member

mattab commented May 17, 2017

Note: there is already this issue which describes problem and possible solution to "educate and mention disabling browser archiving" #6210

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants