Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Safe mode is not displayed when there is a crash/error in some cases #10693

Closed
mattab opened this issue Oct 6, 2016 · 1 comment · Fixed by #10696
Closed

Safe mode is not displayed when there is a crash/error in some cases #10693

mattab opened this issue Oct 6, 2016 · 1 comment · Fixed by #10696
Assignees
@tsteur
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Milestone
3.0.0-b2

Comments

@mattab
Copy link
Member

mattab commented Oct 6, 2016

After upgrading one instance to 3.0.0-b1 the safe mode was not displayed as the Safe mode HTML page was output in the middle a javascript block, as follows

  • to reproduce, install AnonymousPiwikUsageMeasurement v 0.1.4
  • upgrade to 3.0.0-b1
  • it displays the white page of death
  • output of the page is
<!DOCTYPE html>
<html id="ng-app" lang="en" ng-app="piwikApp">
    <head>
                        <meta charset="utf-8">
            <title>Piwik App Usage (opted-in) - 2016 - Web Analytics Reports - Piwik</title>
            <meta http-equiv="X-UA-Compatible" content="IE=EDGE,chrome=1"/>
            <meta name="viewport" content="initial-scale=1.0"/>
            <meta name="generator" content="Piwik - free/libre analytics platform"/>
            <meta name="description" content="Web Analytics report for Piwik&#x20;App&#x20;Usage&#x20;&#x28;opted-in&#x29; - Piwik"/>
            <meta name="apple-itunes-app" content="app-id=737216887" />
            <meta name="google-play-app" content="app-id=org.piwik.mobile2">
                            <meta name="robots" content="noindex,nofollow">

                <link rel="shortcut icon" href="plugins/CoreHome/images/favicon.png"/>
                <link rel="mask-icon" href="plugins/CoreHome/images/applePinnedTab.svg" color="#d4291f">
            <script type="text/javascript">
    var piwik = {};

[............]

    piwik.userLogin = "root";
    piwik.idSite = "1";
    piwik.siteName = "Piwik\x20App\x20Usage\x20\x28opted\x2Din\x29";
    piwik.siteMainUrl = "http\x3A\x2F\x2Fdemo\x2Danonymous.piwik.org";
    piwik.period = "year";
    piwik.currentDateString = "2016-10-06";
    piwik.startDateString = "2016-01-01";
    piwik.endDateString = "2016-10-06";
    piwik.minDateYear = 2015;
    piwik.minDateMonth = parseInt("10", 10);
    piwik.minDateDay = parseInt("15", 10);
    piwik.maxDateYear = 2016;
    piwik.maxDateMonth = parseInt("10", 10);
    piwik.maxDateDay = parseInt("06", 10);
    piwik.language = "en";
    piwik.hasSuperUserAccess = 1;
    piwik.config = {};
    piwik.config = {"action_url_category_delimiter":"\/","autocomplete_min_sites":5,"datatable_export_range_as_day":"rss","datatable_row_limits":["5","10","25","50","100","250","500","-1"],"are_ads_enabled":true};
    <br />
<b>Fatal error</b>:  Class 'Piwik\Plugin\Settings' not found in <b>/home/piwik-demo-anonymous/www/demo-anonymous.piwik.org/plugins/AnonymousPiwikUsageMeasurement/Settings.php</b> on line <b>22</b><br />
<html>
    <head>
        <meta name="robots" content="noindex,nofollow">
        <style type="text/css">
            html, body {
                background-color: white;
            }
            td {
                border: 1px solid #ccc;
                border-collapse: collapse;
                padding: 5px;
            }
            table {
                border-collapse: collapse;
                border: 0px;
            }
            a {
                text-decoration: none;

Expected behavior

The safe mode should be displayed so users can disable the plugin causing the fatal error.
@mattab mattab added the Bug For errors / faults / flaws / inconsistencies etc. label Oct 6, 2016
@mattab mattab added this to the 3.0.0-b2 milestone Oct 6, 2016
@tsteur tsteur mentioned this issue Oct 6, 2016
Merged
@tsteur tsteur self-assigned this Oct 6, 2016
@mattab
Copy link
Member Author

mattab commented Oct 30, 2016

fixed in #10696

@mattab mattab closed this as completed Oct 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tsteur tsteur

Labels
Bug For errors / faults / flaws / inconsistencies etc.
Projects
None yet
Milestone
3.0.0-b2
Development

Successfully merging a pull request may close this issue.

Make sure safemode is shown in case of fatal error while rendering <head> matomo-org/matomo
2 participants
@tsteur @mattab