Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not issue warning/errors during update, when activating a plugin that is already activated #10670

Merged
merged 1 commit into from Oct 4, 2016
Merged

Do not issue warning/errors during update, when activating a plugin that is already activated #10670

merged 1 commit into from Oct 4, 2016

Conversation

mattab
Copy link
Member

@mattab mattab commented Oct 4, 2016

This should fix the build which I broke earlier

  • move PluginDeactivatedException into Exception namespace

---> as a result of this change, we could (should?) remove the try/catch blocks around the activatePlugin calls in all Updates files

@mattab
Do not issue warning/errors during update, when activating a plugin t…
6bdca11 
…hat is already activated

move PluginDeactivatedException into Exception namespace

as a result of this change, we could (should?) remove the try/catch blocks around the activatePlugin calls in all Updates files
@mattab mattab added the Pull Request WIP Indicates the current pull request is still work in progress and not ready yet for a review. label Oct 4, 2016
@mattab mattab added this to the 3.0.0-b1 milestone Oct 4, 2016
@mattab mattab self-assigned this Oct 4, 2016
@mattab mattab merged commit e644d42 into 3.x-dev Oct 4, 2016
@mattab mattab deleted the dont_fail_when_plugin_already_activated branch October 4, 2016 06:41
@mattab mattab added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Oct 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mattab mattab

Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Pull Request WIP Indicates the current pull request is still work in progress and not ready yet for a review.
Projects
None yet
Milestone
3.0.0-b1
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@mattab