Various Api Improvements #10665
Merged
Various Api Improvements #10665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsteur
added
not-in-changelog
tsteur
commented
Oct 4, 2016
| <div piwik-content-block content-title="Piwik.org Blog"> | ||
| <div piwik-widget-loader='{"module":"RssWidget","action":"rssPiwik"}'></div> | ||
| </div> | ||
| <div piwik-widget-loader='{"module":"RssWidget","action":"rssPiwik"}'></div> |
There was a problem hiding this comment.
Here we can see the benefit of rendering widget headlines automatically now, we do not have to define the title twice, we automatically use the widget title defined in the widget
tsteur
commented
Oct 4, 2016
| } | ||
|
|
||
| if (strpos($content, 'piwik-content-block') === false | ||
| && strpos($content, 'class="card"') === false |
There was a problem hiding this comment.
We might not detect in all cases whether someone is using the card css class manually but developers should not do this anyway, they should use piwik-content-block. So it's fine if someone was using class=" card test"
tsteur
commented
Oct 4, 2016
| return true; | ||
| } | ||
|
|
||
| return widget.viewDataTable && (widget.viewDataTable === 'tableAllColumns' || widget.viewDataTable === 'sparklines' || widget.viewDataTable === 'graphEvolution'); |
There was a problem hiding this comment.
we always display them full width
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes were needed in order to make some plugins compatible with Piwik 3:
Background: By default, when there are two widgets on one page, the layout will automatically show them next to each other. However, sometimes a widget might need to be shown full width even when there is more than one widget on a page. I found "wide" better than "full width" property as we might not show it full width
Segment.addSegmentssimilar toWidget.addWidgetConfigs,Report.addReports, etc&showtitle=1) and the widget does not define it, it will automatically make a card with a title out of the widget. This ensures the widget will be shown properly in the dashboard and somewhere else. Otherwise the developer would need to handle this manually and detect whether it is shown in the reporting UI and depending on this render content differently etc.placeholderandrowsThe changes are all in one PR as I'm making some plugins compatible and I need all the changes together in order to make them compatible.