Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the JS error without breaking existing logic #10659

Merged
merged 1 commit into from Oct 3, 2016
Merged

Fix the JS error without breaking existing logic #10659

merged 1 commit into from Oct 3, 2016

Conversation

mattab
Copy link
Member

@mattab mattab commented Oct 3, 2016

if tests pass, this can be merged

fixes #10658

the whole segmentation editor needs to be rewritten in AngularJS with clean code

@mattab mattab added this to the 3.0.0-b1 milestone Oct 3, 2016
@mattab mattab added the answered For when a question was asked and we referred to forum or answered it. label Oct 3, 2016
@mattab mattab self-assigned this Oct 3, 2016
@mattab mattab merged commit c8ec06e into 3.x-dev Oct 3, 2016
@mattab mattab deleted the 10658 branch October 3, 2016 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mattab mattab

Labels
answered For when a question was asked and we referred to forum or answered it.
Projects
None yet
Milestone
3.0.0-b1
Development

Successfully merging this pull request may close these issues.

JavaScript error in some cases when applying a custom segment
1 participant
@mattab