Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Button to add a segment is missing some text in French language #10656

Closed
mattab opened this issue Oct 3, 2016 · 1 comment · Fixed by #10657 or #10897
Closed

Button to add a segment is missing some text in French language #10656

mattab opened this issue Oct 3, 2016 · 1 comment · Fixed by #10657 or #10897
Assignees
@tsteur
Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Regression Indicates a feature used to work in a certain way but it no longer does even though it should.
Milestone
3.0.0-b4

Comments

@mattab
Copy link
Member

mattab commented Oct 3, 2016

Should read Ajouter un segment

the end of the button is not visible

ajouter un
@mattab mattab added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Regression Indicates a feature used to work in a certain way but it no longer does even though it should. labels Oct 3, 2016
@mattab mattab added this to the 3.0.0-b1 milestone Oct 3, 2016
@mattab mattab self-assigned this Oct 3, 2016
@mattab mattab mentioned this issue Oct 3, 2016
Merged
@mattab mattab modified the milestones: 3.0.0-b2, 3.0.0-b1 Oct 4, 2016
@mattab mattab removed their assignment Oct 4, 2016
@mattab mattab modified the milestones: 3.0.0-b2, 3.0.0-b3 Oct 30, 2016
@mattab mattab modified the milestones: 3.0.0-b3, 3.0.0-b4 Nov 14, 2016
@tsteur
Copy link
Member

tsteur commented Nov 23, 2016

The text says actually "Ajouter un nouveau segment". It's shown but not visible because the text is white below. Even when removing the padding it still does not fit in there.It would work when removing all the padding and removing the letter spacing and look like this:

image

I noticed our buttons have a fixed height of 36px and I could remove the height for this one and reduce the line-height so it would look like this:

image

tsteur added a commit that referenced this issue Nov 23, 2016
@tsteur
refs #10656 Button to add a segment is missing some text in French la…
232fa9f 
…nguage
@tsteur tsteur mentioned this issue Nov 23, 2016
Merged
@tsteur tsteur self-assigned this Nov 23, 2016
mattab pushed a commit that referenced this issue Dec 1, 2016
@tsteur @mattab
Button to add a segment is missing some text in French language (#10897
c9244e6 
)

* refs #10656 Button to add a segment is missing some text in French language

* .travis.yml file is out of date, auto-updating .travis.yml file.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tsteur tsteur

Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Regression Indicates a feature used to work in a certain way but it no longer does even though it should.
Projects
None yet
Milestone
3.0.0-b4
2 participants
@tsteur @mattab