Don't force enable low population when using all columns table #10653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not sure why it is enabled there but seems buggy and it doesn't allow plugin developers to disable it
tsteur
added
not-in-changelog
|
It seems to have regressed this: http://builds-artifacts.piwik.org/piwik/piwik/3.x-dev/20336/ViewDataTableTest_4_exclude_low_population.png |
|
The change is supposed to be. It does not exclude low population anymore as it is disabled for that report |
|
This is actually a fix |
|
Ok so the UI test needs to be updated for the "exclude low population" to be UI tested in another report which enables the feature |
|
I have updated the test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please issue pull request against the
3.x-devbranch as themasterbranch currently represents our2.Xversion which is in LTS mode.Important fixes will be merged into
masterif needed after it was merged to3.x-dev.Not sure why it is enabled there but seems buggy and it doesn't allow plugin developers to disable it