Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

While Clicking Email Reports option i got following error "DateTimeZone::__construct(): Unknown or bad timezone (UTC+5.5)" #10639

Closed
mattab opened this issue Oct 3, 2016 · 2 comments
Closed

While Clicking Email Reports option i got following error "DateTimeZone::__construct(): Unknown or bad timezone (UTC+5.5)" #10639

mattab opened this issue Oct 3, 2016 · 2 comments
Assignees
@sgiehl
Labels
Bug For errors / faults / flaws / inconsistencies etc. Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical. Regression Indicates a feature used to work in a certain way but it no longer does even though it should.
Milestone
2.16.5

Comments

@mattab
Copy link
Member

mattab commented Oct 3, 2016 •
edited

As reported by email:

While Clicking Email Reports option i got following error "DateTimeZone::__construct(): Unknown or bad timezone (UTC+5.5)". how can i fix this issue? it was happen after upgrading Piwik 2.16.3.!

I had fixed a similar issue in the update file directly: https://github.com/piwik/piwik/blob/b27cbb96da5a6fd1f7ef1ef90c5c09ca1b875613/core/Updates/2.16.3-b3.php
but didn't notice this code was also duplicated in https://github.com/piwik/piwik/blob/a8f682a6039e9b765e248c6be531cce54a7903d1/plugins/ScheduledReports/Controller.php

Problem is that PHP datetime does not recognise the UTC+x notation.

@sgiehl we need to use our Date class for this to make sure it's all working and tested. Could you please investigate this, as we'll need to patch to 2.16.4 ASAP since it breaks scheduled reports for any user where the site timezone is using UTC+x UTC-y

Would be nice to add a test as well ;)
@mattab mattab added Bug For errors / faults / flaws / inconsistencies etc. Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical. Regression Indicates a feature used to work in a certain way but it no longer does even though it should. labels Oct 3, 2016
@mattab mattab added this to the 2.17.0 milestone Oct 3, 2016
@mattab mattab modified the milestones: 2.17.0, 2.16.4 Oct 3, 2016
@sgiehl sgiehl mentioned this issue Oct 3, 2016
Merged
@mattab
Copy link
Member Author

mattab commented Oct 3, 2016

Fixed in #10651 - we'll release 2.16.4 ASAP

@mattab mattab closed this as completed Oct 3, 2016
@mattab
Copy link
Member Author

mattab commented Oct 4, 2016

Piwik 2.16.5 has been released and fixes this issue. In case your Scheduled reports are not working anymore you may have to re-create them manually, or you can also restore the table piwik_report (containing your Scheduled reports definition) from a backup if you have one. We are sorry for any inconvenience caused.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sgiehl sgiehl

Labels
Bug For errors / faults / flaws / inconsistencies etc. Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical. Regression Indicates a feature used to work in a certain way but it no longer does even though it should.
Projects
None yet
Milestone
2.16.5
Development

No branches or pull requests
2 participants
@mattab @sgiehl