Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn users (in all admin pages) when the PHP version is not recent enough to upgrade Piwik to latest major version #10633

Merged

Conversation

mattab
Copy link
Member

@mattab mattab commented Oct 2, 2016

@mattab mattab added this to the 2.16.3 milestone Oct 2, 2016
@mattab mattab merged commit e692a36 into 2.x-dev Oct 2, 2016
@mattab mattab deleted the notify_users_when_php_needs_upgrade_to_use_latest_major branch October 2, 2016 20:29
@mattab
Copy link
Member Author

mattab commented Oct 2, 2016

It looks like this

warning when php is not recent enough to use latest major piwik version

Also added a note to keep this up to date when we switch major versions in our wiki page about switching major versions checklist: https://github.com/piwik/piwik/wiki/New-major-releases

@mattab mattab added the Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. label Oct 2, 2016
@utrenkner
Copy link

@mattab The warning is good - but it does not seem to work correctly.

On one server we still run Debian 7 with PHP 5.4.x. I just updated Piwik to 2.16.4 but on the "System Check" page, I get contradicting warning messages: One says, I could not update to the LATEST major release. One says that 5.4 will not be supported in the NEXT major release, and the current PHP requirements are listed as PHP version >= 5.3.3... Here is the screenshot:

php-version-warning-screenshot

@mattab
Copy link
Member Author

mattab commented Oct 4, 2016

It's kinda correct it seems: your current version requires 5.3.3 but the next one will require 5.5.9

@utrenkner
Copy link

@mattab The second warning seems correct, as it warns about the next major version.

However, the first one is obviously wrong: It says I cannot install the latest major version unless I upgrade PHP. But the latest version is the one I have already installed.

@mattab
Copy link
Member Author

mattab commented Oct 5, 2016

But the latest version is the one I have already installed.

OK indeed. We are a little too pro-active, but soon there will be a Piwik 3 beta release and hopefully soon the stable release, and we didn't want to have to upgrade the message later, so we "pretend" it's already released. Maybe we should make this better, but it's not too important for me now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants