ControllerResolver.php: return HTTP status 404 if action is not found #10623
Conversation
Hopefully fixes matomo-org#10553 and tells Google to drop error pages from its index.
|
Thanks for PR. It's a good idea to issue 404 to prevent google from indexing the page in the future. I think it would work 👍 Regarding implementation: we wouldn't be able to send the 404 header from within the class. we likely need to create a new exception eg. ActionNotFoundException, throw it in the |
mattab
added
the
Pull Request WIP
|
Hi @fonata do you think you could apply PR review feedback? |
|
I have great respect for your work. Sorry, I won't be able to help as I lack the time to introduce myself to the source and the tests framework. |
|
That's alright @fonata 👍 we'll take a look in coming months (or maybe someone else reading this would be interested to pick this up!) |
|
Thank you for this proposed pull request. Because it was last updated more than one month ago, it is our policy to close pull requests opened for a long time without updates. If you would like to continue work on the pull request, please simply ping us to have it re-opened (after you have pushed a new commit). We hope you understand this and we look forward to seeing an update from you on this pull request or another one! Thanks. |
Hopefully fixes #10553 and tells Google to drop error pages from its index.
Feel free to close instead of merge this if it is too crude. I'd love to know if this triggers any failed automated tests.
Background: A previously-valid URL now shows this output on our server:
.
Google keeps on hitting this page with its Googlebot; PHP writes an entry to the error_log, which our Icinga 2 instance sees.