Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Visitor IP Segment is defined twice #10621

Merged
merged 9 commits into from Oct 3, 2016
Merged

Visitor IP Segment is defined twice #10621

merged 9 commits into from Oct 3, 2016

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Oct 1, 2016

likely was added a second time when merging 2.x => 3.x
Also defined in plugins/CoreHome/Columns/VisitIp.php

@tsteur
Visitor IP Segment is defined twice
1b5698c 
likely was added a second time when merging 2.x => 3.x
Also defined in plugins/CoreHome/Columns/VisitIp.php
@tsteur tsteur added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Oct 1, 2016
@tsteur tsteur added this to the 3.0.0-b1 milestone Oct 1, 2016
@tsteur tsteur added the Needs Review PRs that need a code review label Oct 1, 2016
@mattab
Copy link
Member

mattab commented Oct 3, 2016

Visit ID, Visitor ID, and User ID are also displayed twice.

@mattab mattab self-assigned this Oct 3, 2016
@mattab mattab merged commit d475dd1 into 3.x-dev Oct 3, 2016
@mattab mattab deleted the segmentvisitoriptwice branch October 3, 2016 05:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mattab mattab

Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
3.0.0-b1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tsteur @mattab