Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Creating segments with weird characters sometimes doesn't work #10601

Closed
mattab opened this issue Sep 30, 2016 · 3 comments · Fixed by #10622
Closed

Creating segments with weird characters sometimes doesn't work #10601

mattab opened this issue Sep 30, 2016 · 3 comments · Fixed by #10622
Assignees
@tsteur
Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Regression Indicates a feature used to work in a certain way but it no longer does even though it should.
Milestone
3.0.0-b1

Comments

@mattab
Copy link
Member

mattab commented Sep 30, 2016

Reproduce

  • Create a segment with "Name" is <'>/"#$I*%
  • Click save
  • Getting JavaScript error URIError: malformed URI sequence
  • Expected the segment to save and the page to reload

Worked in Piwik 2
@mattab mattab added c: Performance For when we could improve the performance / speed of Matomo. Regression Indicates a feature used to work in a certain way but it no longer does even though it should. labels Sep 30, 2016
@mattab mattab added this to the 3.0.0-b1 milestone Sep 30, 2016
@mattab mattab added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. and removed c: Performance For when we could improve the performance / speed of Matomo. labels Sep 30, 2016
@mattab
Copy link
Member Author

mattab commented Sep 30, 2016

There is the same problem when the string is set in the segment condition, for example Browser is not <'>/"#$I*%

Error is:

Error: malformed URI sequence
segmentation/getListHtml@https://demo3.piwik.org/index.php?module=Proxy&action=getCoreJs&cb=f5937379c17b5f82590d7726000f17c3:4022:117
segmentation/this.initHtml@https://demo3.piwik.org/index.php?module=Proxy&action=getCoreJs&cb=f5937379c17b5f82590d7726000f17c3:4090:35
segmentation/</<@https://demo3.piwik.org/index.php?module=Proxy&action=getCoreJs&cb=f5937379c17b5f82590d7726000f17c3:4092:93
sf/this.$get</n.prototype.$broadcast@https://demo3.piwik.org/index.php?module=Proxy&action=getCoreJs&cb=f5937379c17b5f82590d7726000f17c3:256:518
k@https://demo3.piwik.org/index.php?module=Proxy&action=getCoreJs&cb=f5937379c17b5f82590d7726000f17c3:223:67
pf/this.$get</</<@https://demo3.piwik.org/index.php?module=Proxy&action=getCoreJs&cb=f5937379c17b5f82590d7726000f17c3:226:121
sf/this.$get</n.prototype.$eval@https://demo3.piwik.org/index.php?module=Proxy&action=getCoreJs&cb=f5937379c17b5f82590d7726000f17c3:254:132
sf/this.$get</n.prototype.$digest@https://demo3.piwik.org/index.php?module=Proxy&action=getCoreJs&cb=f5937379c17b5f82590d7726000f17c3:251:210
sf/this.$get</n.prototype.$apply@https://demo3.piwik.org/index.php?module=Proxy&action=getCoreJs&cb=f5937379c17b5f82590d7726000f17c3:254:428
SegmentSelectorControl/this.changeSegment/</<@https://demo3.piwik.org/index.php?module=Proxy&action=getCoreJs&cb=f5937379c17b5f82590d7726000f17c3:4094:456

https://demo3.piwik.org/index.php?module=Proxy&action=getCoreJs&cb=f5937379c17b5f82590d7726000f17c3
Line 227

@tsteur
Copy link
Member

tsteur commented Oct 1, 2016

FYI: I couldn't reproduce the problem with the segment name so far. Tried various times in different browsers.

@tsteur
Copy link
Member

tsteur commented Oct 1, 2016

In the segment definition it looks like it is related to % so far

tsteur added a commit that referenced this issue Oct 1, 2016
@tsteur
Creating segments with weird characters sometimes doesn't work
5daf6c2 
fixes #10601
@tsteur tsteur mentioned this issue Oct 1, 2016
Merged
@tsteur tsteur self-assigned this Oct 1, 2016
@mattab mattab closed this as completed Oct 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tsteur tsteur

Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Regression Indicates a feature used to work in a certain way but it no longer does even though it should.
Projects
None yet
Milestone
3.0.0-b1
Development

Successfully merging a pull request may close this issue.

Creating segments with weird characters sometimes doesn't work matomo-org/matomo
2 participants
@tsteur @mattab