Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display the "oops" red error message, only when there was an error, do not show it when user clicks away to load another menu or page #10578

Closed
mattab opened this issue Sep 27, 2016 · 7 comments · Fixed by #17292
Labels
Bug For errors / faults / flaws / inconsistencies etc. Regression Indicates a feature used to work in a certain way but it no longer does even though it should.

Comments

@mattab
Copy link
Member

mattab commented Sep 27, 2016

Reproduce

  • In Piwik 3, open the dahsboard
  • while the dashboard is loading, click on a top menu link
  • the dashboard cancels loading the widget, as expected... However
    • Got: a red error notification message
    • Expected instead: no red notification message, as I just clicked away and this is not an error

screenshot

oops not needed

Regression from 2.x

@mattab mattab added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Regression Indicates a feature used to work in a certain way but it no longer does even though it should. labels Sep 27, 2016
@mattab mattab added this to the 3.0.0-b1 milestone Sep 27, 2016
@mattab
Copy link
Member Author

mattab commented Sep 27, 2016

Note: the same problem occurs on other places which should be fixed as well:

  • All websites dashboard
  • the new General Settings/Admin dashboard

@tsteur
Copy link
Member

tsteur commented Sep 27, 2016

I can't reproduce this one on Mac Chrome / FF. Also not sure how we could fix it, only thing I can think of would be to register an unload event listener and then remove all notifications again but it depends which event happens first. showing the notification or unload

@mattab
Copy link
Member Author

mattab commented Oct 3, 2016

We can only reproduce this in Firefox so far, on both Linux and Windows. Tried to find a solution to this problem but really couldn't. Maybe someone else knows how to fix this issue?

@mattab mattab modified the milestones: 3.0.0-b2, 3.0.0-b1 Oct 3, 2016
@mattab mattab modified the milestones: 3.0.0-b2, 3.0.0-b3 Oct 30, 2016
@mattab mattab modified the milestones: 3.0.0-b3, 3.0.0-b4 Nov 14, 2016
@mattab mattab modified the milestones: 3.0.0-b4, 3.0.0-b5 Dec 2, 2016
@mattab mattab added Bug For errors / faults / flaws / inconsistencies etc. and removed not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. labels Dec 5, 2016
@mattab mattab modified the milestones: 3.0.0, 3.0.0-b5 Dec 5, 2016
@sgiehl
Copy link
Member

sgiehl commented May 30, 2017

I'm not even able to reproduce that with latest Firefox on Windows.
Note: Error messages should not be shown if a request gets aborted (see https://github.com/piwik/piwik/blob/3.x-dev/plugins/CoreHome/javascripts/broadcast.js#L565-L568)

@mattab
Copy link
Member Author

mattab commented Jun 21, 2017

fyi Still occurs with Firefox 54 on linux.

@gramakri
Copy link

Ah, I have been trying to figure out the root cause of this issue in our Cloudron installation for a while now. I can confirm that these error messages happen in Firefox 72.0.1 but not in Chrome. I am on linux.

@imc67
Copy link

imc67 commented Jan 30, 2020

Also occurs in Safari 13.0.5 (MacOS)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc. Regression Indicates a feature used to work in a certain way but it no longer does even though it should.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants