Make goal title in report clickable #10571
Conversation
tsteur
added
not-in-changelog
| if (!empty($idSite) && Piwik::isUserHasAdminAccess($idSite)) { | ||
| $view->config->title_edit_entity_url = 'index.php' . Url::getCurrentQueryStringWithParametersModified(array( | ||
| 'module' => 'Goals', | ||
| 'action' => 'manage', |
There was a problem hiding this comment.
FYI: link should go to the Report page, not the manage page (as users will want to click to view more details goal report)
There was a problem hiding this comment.
this is quite tricky currently, it would likely change date etc unless we refactor it quite a bit. Can you check on demo.piwik.org it goes to same page
There was a problem hiding this comment.
it goes to same page, can you just replace the action=index by action=goalReport?
There was a problem hiding this comment.
There was a problem hiding this comment.
I'm having a look. BTW: The links in Piwik 2 are currently broken when exporting it as widgetize. Need to see what to do there
There was a problem hiding this comment.
@mattab it should work now
There was a problem hiding this comment.
The links in Piwik 2 are currently broken when exporting it as widgetize. Need to see what to do there
@tsteur could you create an issue for that one?
There was a problem hiding this comment.
In 3.x they are not clickable when exported so shouldn't be a problem and don't think needs fixing in 2.x or even can be easily fixed
|
Well done, I know that one wasn't easy at all, and result is perfect! |
fixes #10554
Please note that the title shows an underline when hovered so the link is more visible. This is default behaviour that can be changed but will be more useable with underline