@tsteur opened this Pull Request on September 25th 2016 Owner

In https://github.com/piwik/piwik/pull/10502/files we added a property to load the tracker sync. However, we can only make sure it is actually loaded sync when loading it as a separate <script> and not by setting .defer= false; .async = false;

Migrated the template partially to twig. First I moved pretty all the jsCodeImpl variables to twig but then I noticed it is way to risky as some ${...} are defined in the TrackingCode generator class and some in the template, some are escaped while some others are not, the whole template is partially escaped and I don't want to cause any regression here. Therefore for now only partially migrated it to twig.

@mattab commented on September 29th 2016 Owner

@tsteur

otherwise LGTM!

@tsteur commented on September 29th 2016 Owner

done, done & done :)

This Pull Request was closed on September 29th 2016
Powered by GitHub Issue Mirror