Make sure to load Piwik JS tracker synchronously when requested to be loaded sync #10557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsteur
added
not-in-changelog
otherwise LGTM! |
|
done, done & done :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In https://github.com/piwik/piwik/pull/10502/files we added a property to load the tracker sync. However, we can only make sure it is actually loaded sync when loading it as a separate
<script>and not by setting.defer= false; .async = false;Migrated the template partially to twig. First I moved pretty all the jsCodeImpl variables to twig but then I noticed it is way to risky as some
${...}are defined in the TrackingCode generator class and some in the template, some are escaped while some others are not, the whole template is partially escaped and I don't want to cause any regression here. Therefore for now only partially migrated it to twig.