Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In Tracking code, add an option to make page URL tracking case insensitive (useful for sites hosted on Windows) #10534

Open
gaumondp opened this issue Sep 21, 2016 · 9 comments
Labels
Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc.

Comments

@gaumondp
Copy link

The tracking code produced by default doesn't include this line :

_paq.push(['setCustomUrl', location.href.toLowerCase()]);

I don't know why someone would want /mydirectory/ and /mYDirectorY/ be ever separate... I had to include Piwik on a Windows server for the first time and now we got to manually add statistics to get the real numbers.

Software should be be at "best default values"...by default. ;)

Is there a use case I can't see where URL case sensitive makes sense ?

@mattab
Copy link
Member

mattab commented Sep 26, 2016

Hello @gaumondp

Is there a use case I can't see where URL case sensitive makes sense ?

Yes, on a Unix/linux webserver

@mattab mattab closed this as completed Sep 26, 2016
@mattab mattab added the answered For when a question was asked and we referred to forum or answered it. label Sep 26, 2016
@gaumondp
Copy link
Author

Am I wasting time if I ever propose a pull request with a checkbox "Make URL case incentive" and it add "_paq.push(['setCustomUrl', location.href.toLowerCase()]);" in module=CoreAdminHome&action=trackingCodeGenerator ?

@mattab
Copy link
Member

mattab commented Sep 27, 2016

@gaumondp this could work, could you show it when the Advanced button is clicked

@gaumondp
Copy link
Author

@mattab I never, ever, saw that "Advanced" link ! And I've been using Piwik since 2013...

Makes sense to add the option there AND propose a more visible "Advance Settings". I'll create a new feature request.

@siva538
Copy link
Contributor

siva538 commented Apr 29, 2019

+1.

This actually makes sense to have tracking URLs as case insensitive.

While there is a workaround (https://matomo.org/faq/how-to/#faq_90) in place to make the urls as custom and call the lowercase portion on this, it should be part of the core product behavior with some setting/flag etc. to avoid case-sensitive comparison.

Also not all URL's would be custom except the SPA pages.

Regds,
Sivakumar

@siva538
Copy link
Contributor

siva538 commented May 13, 2019

@tsteur , can you please help clarify the reason for marking this as closed? I see the referenced change or pull request was specific to "Download", but this issue #10534 is more generic for handling all the characters in the URL to be case-insensitive, so there is no differentiation in URL's like

http://test.domain.com/Core
OR
http://test.domain.com/core

Am I missing anything here?

@tsteur
Copy link
Member

tsteur commented May 13, 2019

I think it was closed by @mattab since technically these 2 URLs are not the same and it is already possible to workaround by calling setCustomUrl on the tracker.

@siva538
Copy link
Contributor

siva538 commented May 14, 2019

Thanks @tsteur . However it didn't satisfy the initial requirement of making all the URL characters case-insensitive. Also as mentioned above the SetCustomUrl won't help in all cases but just the SPA based pages.

@mattab , can you please reconsider this defect?

@mattab mattab changed the title Make tracking case insensitive by default In Tracking code, add an option to make page URL tracking case insensitive (useful for sites hosted on Windows) May 23, 2019
@mattab mattab added Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. and removed answered For when a question was asked and we referred to forum or answered it. labels May 23, 2019
@mattab mattab reopened this May 23, 2019
@tsteur
Copy link
Member

tsteur commented May 23, 2019

Also as mentioned above the SetCustomUrl won't help in all cases but just the SPA based pages.

It should help in all cases. Works also for non-SPA pages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc.
Projects
None yet
Development

No branches or pull requests

5 participants