Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Let Plugins on the Marketplace offer new geo location providers to complement existing GeoIP provider #10523

Merged
merged 2 commits into from Sep 23, 2016
Merged

Let Plugins on the Marketplace offer new geo location providers to complement existing GeoIP provider #10523

merged 2 commits into from Sep 23, 2016

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Sep 19, 2016 •
edited

Refactors the code for loading available geolocation providers. This should make it easier for potential plugins to provide new location providers.

refs #10431

@sgiehl sgiehl added Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels Sep 19, 2016
@sgiehl sgiehl added this to the 3.0.0-b1 milestone Sep 19, 2016
@mattab mattab merged commit ac7a69a into 3.x-dev Sep 23, 2016
@mattab mattab deleted the improvelocationproviderhandling branch September 23, 2016 04:22
@mattab
Copy link
Member

mattab commented Sep 23, 2016

Useful 👍

@mattab mattab mentioned this pull request Sep 23, 2016
Closed
@mattab mattab changed the title Improves handling of Geolocation providers (3.x) Let Plugins on the Marketplace offer new geo location providers to complement existing GeoIP provider Sep 26, 2016
@mattab mattab removed the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Sep 26, 2016
@mattab
Copy link
Member

mattab commented Sep 26, 2016

Removed not-in-changelog as it's a new feature that deserves to be advertised in changelog 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. Needs Review PRs that need a code review
Projects
None yet
Milestone
3.0.0-b1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sgiehl @mattab