Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure to set an entry page if none was set before #10510

Merged
merged 8 commits into from Sep 19, 2016
Merged

Make sure to set an entry page if none was set before #10510

merged 8 commits into from Sep 19, 2016

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Sep 17, 2016

This fixes that no entry page is set if eg first an event is tracked and then a pageview. Currently it would totally miss the entry page

@tsteur tsteur added Pull Request WIP Indicates the current pull request is still work in progress and not ready yet for a review. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. labels Sep 17, 2016
@tsteur tsteur added this to the 2.16.3 milestone Sep 17, 2016
@tsteur tsteur added Needs Review PRs that need a code review and removed Pull Request WIP Indicates the current pull request is still work in progress and not ready yet for a review. labels Sep 17, 2016
@tsteur
Copy link
Member Author

tsteur commented Sep 17, 2016

@mattab can you have a look at the changed system tests data?

@mattab mattab mentioned this pull request Sep 19, 2016
Closed
@mattab
Copy link
Member

mattab commented Sep 19, 2016

Had to change the field to DEFAULT NULL as otherwise it defaulted to 0 which caused conflicts with Site Searches which are stored with idaction_url = 0... Ideally we wouldn't use such magic values "idaction_url = 0 means site search" and hopefully we'll improve this in a next major release 👍

@mattab mattab merged commit 39b5cba into 2.x-dev Sep 19, 2016
@mattab mattab deleted the entrypagefix branch September 19, 2016 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
2.16.3
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tsteur @mattab