Add possibility to retry _paq plugin method calls at a later point #10502
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This might be easiest to explain by looking at the test in https://github.com/piwik/piwik/pull/10502/files#diff-61dc9c2c1c7174d2576a20aa38f753b9R620
There might be plugin calls like
and it would not execute these calls if it first loads piwik.js and then later the tracker plugin (only if piwik.js is not writable and the plugin tracker was loaded separately).
To make sure those methods get still executed a tracker plugin can call
Piwik.retryMissedPluginCalls();
as soon as it is loaded so these methods will be actually executed and not "missed". If there's a better name for that method let me know. I was thinking aboutPiwik.setPluginLoaded
or something like this but not sure about that as it's not always needed to retry in all cases and as long as it's not official API I rather have a concrete method name for that so it is clear what it does