Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make all log_* tables fields NULLable #10492

Merged
merged 3 commits into from Sep 20, 2016
Merged

Make all log_* tables fields NULLable #10492

merged 3 commits into from Sep 20, 2016

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Sep 13, 2016

fixes #9231

failing ui tests: http://builds-artifacts.piwik.org/piwik/piwik/9231/19892/

CoreUpdaterDb_main.png is because of this change and expected. The other 2 are currently random build failures.

@tsteur tsteur added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels Sep 13, 2016
@tsteur tsteur added this to the 3.0.0-b1 milestone Sep 13, 2016
@mattab
Copy link
Member

mattab commented Sep 20, 2016

Test the PR as follows:

  • Applied schema changes
  • Then run
show create table piwik_log_visit;
show create table piwik_log_action;
show create table piwik_log_conversion;
show create table piwik_log_conversion_item;
show create table piwik_log_link_visit_action;
  • the fields still NOT NULL seem to be all defined in the CoreHome plugin (not de-activable). some fields from log_conversion are defined in Goals and Ecommerce plugin.
  • manually tested a Goal conversion and Ecommerce conversions afte de-activating Goal and Ecommerce plugins respectively, and both requests were partially tracked without failing

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make all log_* tables fields NULLable to prevent errors "Field 'X' doesn't have a default value"
2 participants