Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make resolution field bigger #10489

Merged
merged 2 commits into from Sep 13, 2016
Merged

Make resolution field bigger #10489

merged 2 commits into from Sep 13, 2016

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Sep 13, 2016

fixes #9913

Allows us to eg persistent a resolution like 99999.12x99999.12

@tsteur tsteur added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels Sep 13, 2016
@tsteur tsteur added this to the 3.0.0-b1 milestone Sep 13, 2016
@sgiehl
Copy link
Member

sgiehl commented Sep 13, 2016

LGTM. Btw as we now have Git LFS. We can directly update the screenshots in Pull Requests. Guess http://builds-artifacts.piwik.org/piwik/piwik/9913/19886/CoreUpdaterDb_main.png fails cause of this change.

@tsteur
Copy link
Member Author

tsteur commented Sep 13, 2016

good point. I've just copied the file into expected-screenshots but git doesn't show me a changed file. Do I need to do anything special re git-lfs? I remember it did download all the files when I checked out 3.x-dev a while ago

@sgiehl
Copy link
Member

sgiehl commented Sep 13, 2016

I tried exactly that right now, and it shows me the changed file. Maybe the screenshots are not correctly checked out, try:

git lfs fetch
git lfs checkout

@tsteur
Copy link
Member Author

tsteur commented Sep 13, 2016

Just tried it without

vagrant@piwik-trusty64:~/www/piwik$ git lfs fetch
Fetching 9913
(0 of 308 files) 0 B / 39.19 MB                                                                                                                                                     
vagrant@piwik-trusty64:~/www/piwik$ git lfs checkout
(333 of 333 files) 40.00 MB / 40.00 MB                

not sure if the 0 of 308 files is so good. I'll update my git. Still on git version 1.9.1 :) maybe that helps

@sgiehl
Copy link
Member

sgiehl commented Sep 13, 2016

On my box (using git 2.7) it says:

Fetching 9913
Git LFS: (0 of 0 files, 308 skipped) 0 B / 0 B, 39.19 MB skipped

@tsteur
Copy link
Member Author

tsteur commented Sep 13, 2016

Just updated to git version 2.9.3 and same problem. Need to look into it tmrw I reckon

@tsteur
Copy link
Member Author

tsteur commented Sep 13, 2016

I'm so stupid :) I copied the picture into another project that also had an expected-screenshots folder :)

@tsteur tsteur merged commit e46a532 into 3.x-dev Sep 13, 2016
@tsteur tsteur deleted the 9913 branch September 13, 2016 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DB field name Screen resolution is too small: width and height should not be limited to 9999 pixels
2 participants